Remove strict checkpoint logic

ash0ts · Dec 1, 2023 · 7de4ba5 · 7de4ba5
1 parent 55466a9
commit 7de4ba5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/lightning/fabric/loggers/wandb.py b/src/lightning/fabric/loggers/wandb.py
@@ -655,9 +655,9 @@ def save(self) -> None:
     @override
     @rank_zero_only
     def finalize(self, status: str) -> None:
-        if status != "success":
-            # Currently, checkpoints only get logged on success
-            return
+        # if status != "success":
+        #     # Currently, checkpoints only get logged on success
+        #     return
         # log checkpoints as artifacts
         if self._checkpoint_callback and self._experiment is not None:
             self._scan_and_log_pytorch_checkpoints(self._checkpoint_callback)

diff --git a/src/lightning/pytorch/loggers/wandb.py b/src/lightning/pytorch/loggers/wandb.py
@@ -628,9 +628,9 @@ def use_artifact(self, artifact: str, artifact_type: Optional[str] = None) -> "A
     @override
     @rank_zero_only
     def finalize(self, status: str) -> None:
-        if status != "success":
-            # Currently, checkpoints only get logged on success
-            return
+        # if status != "success":
+        #     # Currently, checkpoints only get logged on success
+        #     return
         # log checkpoints as artifacts
         if self._checkpoint_callback and self._experiment is not None:
             self._scan_and_log_checkpoints(self._checkpoint_callback)