Adapted attachment input component to use Bulma CSS styling, show nam… #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of attached file under preview icon, add .sass-lint.yml (TODO)
whitphx
reviewed
Sep 2, 2018
| @@ -177,6 +177,7 @@ class AttachmentViewerComponent extends Component { | |||
| return ( | |||
| <div key={m.id} className="column is-narrow"> | |||
| {content} | |||
| <div>{m.name}</div> | |||
There was a problem hiding this comment.
Can you please handle the case where the filename is too long?
I think it's good to insert ... into the middle of filename like TOO_LO...AME.png
There was a problem hiding this comment.
Oh! Got it, will do :)
There was a problem hiding this comment.
Please pull newest changes & take a look
| const meta = Array(files.length); | ||
| const attachments = {}; | ||
| const idPromises = Array(files.length); | ||
| for (let i = 0; i < files.length; i++) { |
There was a problem hiding this comment.
Why did you change it?
Yes, this is no problem and, in practice, these are equivalent and there is no strong reason to choose the one.
Therefore I think I can't find the reason to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e of attached file under preview icon, add .sass-lint.yml (TODO)
In addressing issue #594