fix(conditions): generic condition had exit and init reversed

Didn't seem to cause any problems. But would have definitely caused issues with extending the ConditionGeneric class.
ashblue · Mar 30, 2021 · c9ac8cc · c9ac8cc
1 parent c612443
commit c9ac8cc
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/Assets/FluidBehaviorTree/Runtime/Tasks/Conditions/ConditionGeneric.cs b/Assets/FluidBehaviorTree/Runtime/Tasks/Conditions/ConditionGeneric.cs
@@ -20,11 +20,11 @@ protected override void OnStart () {
         }
 
         protected override void OnExit () {
-            initLogic?.Invoke();
+            exitLogic?.Invoke();
         }
 
         protected override void OnInit () {
-            exitLogic?.Invoke();
+            initLogic?.Invoke();
         }
     }
 }
diff --git a/Assets/FluidBehaviorTree/Tests/Editor/Tasks/Conditions/ConditionGenericTest.cs b/Assets/FluidBehaviorTree/Tests/Editor/Tasks/Conditions/ConditionGenericTest.cs
@@ -44,6 +44,20 @@ public void It_should_execute_a_init_hook () {
                 Assert.AreEqual(1, test);
             }
 
+
+            [Test]
+            public void It_should_execute_init_hook_before_update () {
+                var test = 0;
+                var task = new ConditionGeneric {
+                    initLogic = () => { test++; },
+                    updateLogic = () => { return test == 1; }
+                };
+
+                task.Update();
+
+                Assert.AreEqual(task.LastStatus, TaskStatus.Success);
+            }
+
             [Test]
             public void It_should_execute_a_exit_hook () {
                 var test = 0;