Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong method invocation in base class ActionGeneric.cs #35

Closed
eLeSTRaGo-Dev opened this issue Feb 4, 2021 · 7 comments
Closed

Wrong method invocation in base class ActionGeneric.cs #35

eLeSTRaGo-Dev opened this issue Feb 4, 2021 · 7 comments
Labels
working on it

Comments

@eLeSTRaGo-Dev
Copy link

In script ActionGeneric.cs method OnExit call initLogic and OnInit call exitLogic.

protected override void OnExit () {
    initLogic?.Invoke();
}

protected override void OnInit () {
    exitLogic?.Invoke();
}
@piotr-j piotr-j mentioned this issue Mar 22, 2021
Closed
@ashblue
Copy link
Owner

ashblue commented Mar 23, 2021

Oh crap, that is definitely wrong. I'm not sure why I didn't get an email about this (or how I've been using this project and never noticed it). I'll get this fixed first thing tomorrow after work.

Repository owner deleted a comment from allcontributors bot Mar 24, 2021
@ashblue
Copy link
Owner

ashblue commented Mar 24, 2021

@all-contributors add @eLeSTRaGo-Dev for 🐛

@allcontributors
Copy link
Contributor

@ashblue

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@ashblue
Copy link
Owner

ashblue commented Mar 24, 2021

@all-contributors add @piotr-j for code

@allcontributors allcontributors bot mentioned this issue Mar 24, 2021
Merged
@allcontributors
Copy link
Contributor

@ashblue

I've put up a pull request to add @piotr-j! 🎉

@ashblue
Copy link
Owner

ashblue commented Mar 24, 2021

@eLeSTRaGo-Dev it wont let me add you via all contributors, not sure why 🤔 Maybe privacy settings???

ashblue added a commit that referenced this issue Mar 24, 2021
@ashblue
fix(actions): generic action had exit and init reversed
6dce48f 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue added a commit that referenced this issue Mar 24, 2021
@ashblue
fix(actions): generic action had exit and init reversed
ff7dbc2 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
This was referenced Mar 24, 2021
Closed
Merged
ashblue added a commit that referenced this issue Mar 24, 2021
@ashblue
fix(actions): generic action had exit and init reversed
0381668 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue pushed a commit that referenced this issue Mar 24, 2021
@semantic-release-bot
chore(release): 2.2.3 [skip ci]
8fd19f8 
## [2.2.3](v2.2.2...v2.2.3) (2021-03-24)

### Bug Fixes

* **actions:** generic action had exit and init reversed ([ff7dbc2](ff7dbc2)), closes [#35](#35)
ashblue added a commit that referenced this issue Mar 24, 2021
@ashblue
fix(actions): generic action had exit and init reversed
4a50c22 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue pushed a commit that referenced this issue Mar 24, 2021
@semantic-release-bot
chore(release): 2.2.3 [skip ci]
5d2f47a 
## [2.2.3](v2.2.2...v2.2.3) (2021-03-24)

### Bug Fixes

* **actions:** generic action had exit and init reversed ([ff7dbc2](ff7dbc2)), closes [#35](#35)
* **builds:** node version now pulls from .nvmrc ([bf5c108](bf5c108))
@ashblue
Copy link
Owner

ashblue commented Mar 24, 2021

Fixed. Travis CI was being a pain when I had to upgrade it (sorry for all the closed and re-opened tickets).

https://github.com/ashblue/fluid-behavior-tree/releases/tag/v2.2.3

@ashblue ashblue closed this as completed Mar 24, 2021
ashblue added a commit that referenced this issue Mar 24, 2021
@ashblue
fix(actions): generic action had exit and init reversed
e5a264a 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue pushed a commit that referenced this issue Mar 27, 2021
@semantic-release-bot @ashblue
chore(release): 2.2.3 [skip ci]
36ee899 
## [2.2.3](v2.2.2...v2.2.3) (2021-03-24)

### Bug Fixes

* **actions:** generic action had exit and init reversed ([ff7dbc2](ff7dbc2)), closes [#35](#35)
ashblue pushed a commit that referenced this issue Mar 27, 2021
@semantic-release-bot @ashblue
chore(release): 2.2.3 [skip ci]
c04b55b 
## [2.2.3](v2.2.2...v2.2.3) (2021-03-24)

### Bug Fixes

* **actions:** generic action had exit and init reversed ([ff7dbc2](ff7dbc2)), closes [#35](#35)
* **builds:** node version now pulls from .nvmrc ([bf5c108](bf5c108))
ashblue added a commit that referenced this issue Mar 27, 2021
@ashblue
fix(actions): generic action had exit and init reversed
b33c599 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue added a commit that referenced this issue Mar 27, 2021
@ashblue
fix(actions): generic action had exit and init reversed
85bbf54 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue added a commit that referenced this issue Apr 2, 2021
@ashblue
fix(actions): generic action had exit and init reversed
a61b94e 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue added a commit that referenced this issue Apr 4, 2021
@ashblue
fix(actions): generic action had exit and init reversed
abbe8d9 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue added a commit that referenced this issue Apr 4, 2021
@ashblue
fix(actions): generic action had exit and init reversed
94e231b 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
ashblue added a commit that referenced this issue Apr 7, 2021
@ashblue
fix(actions): generic action had exit and init reversed
029c258 
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ActionGeneric class.

#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashblue @eLeSTRaGo-Dev