Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tvOS version from 9.0 to 10.0 #213

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

hufkens
Copy link
Contributor

@hufkens hufkens commented Nov 10, 2020

This is necessary because the dependency doesn't compile anymore.

.../Pods/Nimble-Snapshots/Nimble_Snapshots/HaveValidSnapshot.swift:1:8: Compiling for tvOS 9.0, but module 'FBSnapshotTestCase' has a minimum deployment target of tvOS 10.0: ...-bwcvxbxvnwfwrqdcekdprthjvvbq/Build/Products/Testing-appletvsimulator/iOSSnapshotTestCase/FBSnapshotTestCase.framework/Modules/FBSnapshotTestCase.swiftmodule/x86_64-apple-tvos-simulator.swiftmodule

This is necessary because the dependency doesn't compile anymore.

Error: Compiling for tvOS 9.0, but module 'FBSnapshotTestCase' has a minimum deployment target of tvOS 10.0
@dogo
Copy link
Collaborator

dogo commented Nov 11, 2020

Seems fine to me. Can we merge @ashfurrow ?

@dogo dogo added the bug label Nov 11, 2020
Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good. I'll get this released later toady. Thanks for the PR!

@ashfurrow ashfurrow merged commit 368f850 into ashfurrow:master Nov 23, 2020
@ashfurrow-peril
Copy link

Thanks a lot for contributing @hufkens! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow
Copy link
Owner

Okay! That's been released as version 9.1.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants