Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRFI-1 append! and append not equivalent #944

Closed
ekaitz-zarraga opened this issue Jan 8, 2024 · 1 comment · Fixed by #945
Closed

SRFI-1 append! and append not equivalent #944

ekaitz-zarraga opened this issue Jan 8, 2024 · 1 comment · Fixed by #945

Comments

@ekaitz-zarraga
Copy link
Contributor

Hi,

I noticed append! doesn't work when the first list is empty and that is not equivalent to what append does, which just works.

I think there's some bug in append!'s implementation, that relies on the first element having a cdr which it may not have.

I'll try to find a fix and propose it.

Thanks!
@ekaitz-zarraga
Copy link
Contributor Author

So, digging in the code append! is calling concatenate! which also has the same issue.

@ekaitz-zarraga ekaitz-zarraga mentioned this issue Jan 8, 2024
Merged
ashinn added a commit that referenced this issue Jan 9, 2024
@ashinn
Merge pull request #945 from ekaitz-zarraga/concatenate!
cc6a3d1 
Fix #944: concatenate! work with empty lists in any position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #944: concatenate! work with empty lists in any position ekaitz-zarraga/chibi-scheme
1 participant
@ekaitz-zarraga