Fix documentation on building a standalone statically linked executable including compiled libs #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, sorry, this is already set in the build tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one-liner adjusts the documentation on building a standalone static executable with all compiled libraries.
If I am not mistaken, the preprocessor flag
SEXP_USE_STATIC_LIBS_NO_INCLUDE=0must be present when compilingeval.cin order to include the generatedclibs.c- otherwiseSEXP_USE_STATIC_LIBS_NO_INCLUDEwill be set to 1 infeatures.h, and I believe this is not what the docs are trying to show (also, linking fails due to a missingsexp_static_librariessymbol, as tested on MacOS and Linux ARM).