Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax-tests to use mutable-environment #871

Merged
merged 2 commits into from
Oct 30, 2022

Conversation

dpk
Copy link
Contributor

@dpk dpk commented Oct 28, 2022

The AppVeyor cmake build was failing because the identifier syntax tests used environment assuming its result was mutable; this broke as of 0eeeac7.

This patch also adds the syntax-tests to the test-all suite, so similar regressions in future will be caught by all the CI builds failing, not just the AppVeyor one.

@ashinn ashinn merged commit d296578 into ashinn:master Oct 30, 2022
@ashinn
Copy link
Owner

ashinn commented Oct 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants