Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index-swap, fix assert in array-append #918

Merged
merged 1 commit into from
May 24, 2023
Merged

Add index-swap, fix assert in array-append #918

merged 1 commit into from
May 24, 2023

Conversation

gambiteer
Copy link
Contributor

These changes are untested.

Copy link
Owner

@ashinn ashinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashinn ashinn merged commit ef55402 into ashinn:master May 24, 2023
@gambiteer
Copy link
Contributor Author

I noticed that some arguments were protected by asserts, and others were not.
Do you want argument checks for all arguments?

@ashinn
Copy link
Owner

ashinn commented May 24, 2023

Yes, in general there should be more checks. This is still a WIP but I hope to wrap up soon. Notably array-block is not implemented, and the signature of make-specialized-array is incorrect (and probably a few other details).

@gambiteer gambiteer deleted the 231-changes branch May 25, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants