Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle basic special characters in write #939

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

raviqqe
Copy link
Contributor

@raviqqe raviqqe commented Sep 27, 2023

This PR fixes the implementation of write in SRFI 38 with special characters (e.g. newline and tab) as described in the section "6.13.3. Output" in the R7RS.

@raviqqe
Copy link
Contributor Author

raviqqe commented Sep 28, 2023

Ah, it looks like it's not necessary to escape them with their names but we can put any character after #\. I'm gonna just close this.

@raviqqe raviqqe closed this Sep 28, 2023
@ashinn ashinn reopened this Sep 29, 2023
@ashinn
Copy link
Owner

ashinn commented Sep 29, 2023

We should write the descriptive names. We can either use this list or punt to the underlying write like we do for numbers.

@ashinn ashinn merged commit fe93067 into ashinn:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants