Avoid needless allocation in read-bytevector! #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change switches the implementation strategy to basing read-bytevector on top of read-bytevector! rather than the other way around.
wasamasa
force-pushed
the
optimize-read-bytevector
branch
from
228edb8 to
d0e6dc7
Compare
ashinn
requested changes
Mar 18, 2024
ashinn
reviewed
Mar 18, 2024
lib/scheme/extras.scm
Outdated
| @@ -135,36 +135,31 @@ | |||
| (if (zero? n) | |||
| #u8() | |||
| (let ((in (if (pair? o) (car o) (current-input-port))) | |||
ashinn
requested changes
Mar 18, 2024
lib/scheme/extras.scm
Outdated
| (res (read-bytevector! vec in))) | ||
| (cond ((eof-object? res) res) | ||
| ((< res n) (subbytes vec 0 i)) | ||
| (else res))))) |
There was a problem hiding this comment.
Suggested change
| (else res))))) | |
| (else vec))))) |
lib/scheme/extras.scm
Outdated
| (vec (make-bytevector n)) | ||
| (res (read-bytevector! vec in))) | ||
| (cond ((eof-object? res) res) | ||
| ((< res n) (subbytes vec 0 i)) |
There was a problem hiding this comment.
Suggested change
| ((< res n) (subbytes vec 0 i)) | |
| ((< res n) (subbytes vec 0 res)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches the implementation strategy to basing read-bytevector on top of read-bytevector! rather than the other way around. Bonus: It's a bit less code than previously and is less surprising to the reader.