Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send image urls #956

Merged
merged 78 commits into from
Nov 7, 2023
Merged

Send image urls #956

merged 78 commits into from
Nov 7, 2023

Conversation

TylerNoblett
Copy link
Collaborator

@TylerNoblett TylerNoblett commented Oct 18, 2023

Sends presigned url for images stored on s3, so that the backend doesn't have to load all of them before sending the evidence data

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@TylerNoblett
Copy link
Collaborator Author

TylerNoblett commented Oct 24, 2023

Alright! I'm able to the get the urls and pull the images out of band, and nothing is broken on development, so I think it's good to go. Once you guys approve, I'll squash the commits down into one since it got out of hand

@TylerNoblett TylerNoblett changed the title DRAFT: Tn/send image urls Send image urls Oct 24, 2023
@jrozner
Copy link
Member

jrozner commented Oct 26, 2023

Given that we support gpc as an alternative backend for storage, are we going to land the changes to support the equivalent there before merging?

@TylerNoblett
Copy link
Collaborator Author

TylerNoblett commented Oct 26, 2023

Given that we support gpc as an alternative backend for storage, are we going to land the changes to support the equivalent there before merging?

Good question! I added the code for gpc this morning (in a separate branch), but haven't tested it yet. I would assume that these changes will be wayyy faster and worth it, but thought I would let you guys test the AWS side of things, before I bother Chris and get him to setup everything on gpc. I can go ahead and ping him about it now though working with Chris to get an env setup in gcp

@jkennedyvz jkennedyvz merged commit 5d49edf into main Nov 7, 2023
@TylerNoblett TylerNoblett deleted the tn/send-image-urls branch November 7, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants