Add tests on annotation production and fix "undefined" in annotations #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JUnit XML DTD indicate that some arguments are optionals. To avoid having NaN numbers, missing values are transformed to 0.
The test name and failure message were undefined. This is fixed. Also the JUnit XML DTD indicate that failure message is not required, so missing value is supported. Setting numFailures parameter to -1 will transform all failures into annotations without limit.
Before, without title, the file path were used as annotation title. But, this information is already visible at the top of the annotation. To maximize the amount of information, this define the test case name as title. Also, the failure message (generally the stack trace) is provided as raw_details of the annotation. Note that this raw_details is folded by GitHub, so it won't reduce the readability of annotations.
|
That's weird, I have no idea why the tests are failing. They are good on my fork: https://github.com/TurpIF/junit-report-annotations-action/actions/runs/178849846 |
This was referenced Jul 24, 2020
|
Hey @ashley-taylor, love the plugin. The fix for #12 in this PR is also useful for us at ls1intum/Artemis. Would you mind releasing a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings unit tests on:
This add simulated failures in the embedded JUnit report to automatically generate example of the plugin in its own GitHub Action run (see https://github.com/TurpIF/junit-report-annotations-action/runs/899761676?check_suite_focus=true for instance).
By adding the test, few bugs were fixed:
numFailuresto-1, there is no limit of annotationsFor #14, the line and file are still when not using java-like structure (with tests under src).