-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix links to point current (0.2) branch instead of master branch #314
Conversation
My goal was to phase out the existing master branch (and go forward using the current 0.2 branch under a new name) rather soon (this week or next). There are only some things that needed to be fixed before we could clean up the old master branch:
But you are right that this transition phase could be a little cleaner.
I am merging this is in now regardless since I'd rather have a consistent state (instead of half the links pointing to one branch and the other half pointing to a different one). As soon as we rename this branch to master we can fix them again.
I think it's better to go forward without the branch name "master" to minimize confusion for people updating old gekko clients. What do you think of the following?
I'll see how fast I can fix the issues in the above list to rename the 0.2 branch to "stable". The last item on the list is what stopped me from renaming the current "master" branch, I am afraid what will happen to those PRs (only 2 left now). |
Sounds good to me. |
I now created two branches:
All links point to the stable branch (unless it is about something that changed in the develop branch). The 0.2 branch is now deleted. |
Awesome! And |
I rather add that to a |
From my previous experience i know that only a small part of contributors read contribution guidelines. So lots of people were opening PRs against stable branch and I wrote a bot which points them what did they do wrong and checks if the opened PR follows repo's contribution guidelines. |
I get a few pull requests a week max. But Gekko has over 150 downloads a week. I rather have all these people downloading the stable version. |
Awesome, sound reasonable to me 👍 |
To keep documentation always up to date in this branch.
@askmike for future, I think it is a good idea to change your branching model. Gekko won't be 0.2 forever thus when you move to next version (hopefully, 1.0.0) these links need to be updated again to point to current renamed branch.
So my suggestion is archive
master
branch by renaming it something likeold-gekko
or whatever, then checkout newmaster
from current0.2
branch, rename0.2
tostaging
ordevelopement
.So the result is
staging
ordevelopement
branch (formerly0.2
) is where all development goes, new features, bug fixes etc.,master
branch (formerly latest0.2
) is where latest stable code is pushed from current development branch. So develope instaging
and once code is stable, push tomaster
.Note, if you decide to do that now, then you'd to that before merging this PR BUT after you handle all other PRs (merge/close them), otherwise links in new
master
branch will point to0.2
branch which won't exist anymore after renaming is done.And another question. Those three PRs are open against current
master
branch which is obsolete. Should we close them and open new PRs against0.2
branch?