Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
is faster for inclusion checks than Array —O(1)
vsO(n)
. When generating a lot of fake data that you need to be unique, it makes a pretty big difference. I discovered this while creating 100k test users in my DB with a unique constraint on email addresses.It even makes a huge difference for this test suite. The difference in runtime on my machine for the
generate unique result
test is 656ms vs 49ms, or 12x as fast.Before this commit:
After this commit: