Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Widget display on Categories Page and Fix Text Color using textContrastClass #50

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Support Widget display on Categories Page and Fix Text Color using textContrastClass #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8e5fcb8
Support Widget display for categories, such as Statistics Widget, Cus…
Yippy Apr 28, 2024
efbfb11
Fix #25 Use textContrastClass to switch between white and black font …
Yippy Apr 29, 2024
e8d7b05
Redo dark theme support, removed declared colors and use css names to…
Yippy Apr 29, 2024
6438324
Fix typo and rephrase sentence
Yippy May 1, 2024
3ed4065
Fix ordering of ItemList
Yippy May 9, 2024
b738e44
Improved widget container finder with the add findWidgetContainer fun…
Yippy May 10, 2024
116e4c2
Add new helper lastDiscussionAvatar, to support 'Anonymous' users tha…
Yippy May 10, 2024
1df2160
Remove usage of icon, use '?' instead
Yippy May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion extend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,13 @@
->serializeToForum('categories.parentRemoveDescription', 'askvortsov-categories.parent-remove-description', 'boolval')
->serializeToForum('categories.parentRemoveStats', 'askvortsov-categories.parent-remove-stats', 'boolval')
->serializeToForum('categories.parentRemoveLastDiscussion', 'askvortsov-categories.parent-remove-last-discussion', 'boolval')
->serializeToForum('categories.childBareIcon', 'askvortsov-categories.child-bare-icon', 'boolval', true),
->serializeToForum('categories.childBareIcon', 'askvortsov-categories.child-bare-icon', 'boolval', true)
->serializeToForum('categories.widgetHeader', 'askvortsov-categories.widget-header', 'boolval', false)
->serializeToForum('categories.widgetRight', 'askvortsov-categories.widget-right', 'boolval', false)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not default these to true? If someone has installed a widget extension, presumably they want widgets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely, I though it was better to turn them off by default with the original categories page. No one seems to have complained about not having widgets on the page. The original didn't have header, footer or right side widget. Only there was a bug for allowing the widget to show on the left sidebar, which I accidently fixed. This PR was to make it almost like before, but with options

->serializeToForum('categories.widgetLeft', 'askvortsov-categories.widget-left', 'boolval', false)
->serializeToForum('categories.widgetFooter', 'askvortsov-categories.widget-footer', 'boolval', false)
->serializeToForum('categories.enablePrimaryTagColor', 'askvortsov-categories.enable-primary-tag-color', 'boolval', true)
->serializeToForum('categories.enablePrimaryChildTagColor', 'askvortsov-categories.enable-primary-child-tag-color', 'boolval', false),

(new Extend\ApiController(ListTagsController::class))
->addOptionalInclude('lastPostedDiscussion.lastPostedUser'),
Expand Down
2 changes: 1 addition & 1 deletion js/dist/admin.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion js/dist/admin.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading