-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange layout of components #93
Comments
Ok, apparently the shiny new TileToRowCCPacker from OGDF was doing some strange things in some cases. So, I went ahead and ported old "embedded" packer which seems to work better and has some useful features. I'm having the following packing of components which look reasonable to me given the aspect ratio |
That looks reasonable to me as well. The old version used to sort them by size, which was nice in some ways, but I don't have a strong preference. |
Oh ok interesting. I didn't expect aspect ratio to make all the difference. I assumed the threading is what reordered things. Thanks |
Oh, no. The components are always processed being sorted by height (and first optionally rotated to be more "horizontal"). So, yes, sometimes small components could fit into spare spot |
Hmm ok. Well this has for some reason put every component in one row, which doesn't seem very space efficient

Compare this to the original packing method:

Originally posted by @rlorigro in #91 (comment)
The text was updated successfully, but these errors were encountered: