rewrite six.moves.range

[MarcoGorelli]

closes #340

[asottile]

there's quite a few more that should get handled probably: https://github.com/asottile/reorder_python_imports/blob/006b2ee37e304bdcb7b3c7ea6a0b1079c9cf999e/reorder_python_imports.py#L651-L728

[MarcoGorelli]

I'm not sure I see how - those in REMOVALS are already handled here

pyupgrade/pyupgrade/_main.py

Line 414 in ca5d7df

'six.moves': ('filter', 'input', 'map', 'range', 'zip'),

and those in REPLACES would require extra imports. E.g. I can't rewrite

six.moves.BaseHTTPServer

to

http.server

because that would require http to have been imported, which as far as I understand is out of scope for pyupgrade

[asottile]

ah I guess I misunderstood what this PR was aiming at, the REPLACES is only for from imports -- can always do that in another PR

[asottile]

since they're currently always range -- this can just be inlined as 'range' right?

[asottile]

should this get added to the existing six module ?

[MarcoGorelli]

ah I guess I misunderstood what this PR was aiming at, the REPLACES is only for from imports -- can always do that in another PR

ah, so to rewrite e.g.

from six import StringIO
from six.moves.builtins import bool

to

from io import StringIO
from builtins import bool

?

Sure, sounds good, I'll try that in a separate PR (and'll update this one later)

[asottile]

ah I guess I misunderstood what this PR was aiming at, the REPLACES is only for from imports -- can always do that in another PR

ah, so to rewrite e.g.

from six import StringIO
from six.moves.builtins import bool

to

from io import StringIO
from builtins import bool

?

Sure, sounds good, I'll try that in a separate PR (and'll update this one later)

yep! though actually the six.moves.builtins ones should just be dropped I imagine

[asottile]

[graingert]

Hyped for Monday already

[MarcoGorelli]

ah I guess I misunderstood what this PR was aiming at, the REPLACES is only for from imports -- can always do that in another PR

ah, so to rewrite e.g.

from six import StringIO
from six.moves.builtins import bool

to

from io import StringIO
from builtins import bool

?
Sure, sounds good, I'll try that in a separate PR (and'll update this one later)

yep! though actually the six.moves.builtins ones should just be dropped I imagine

Just to clarify - would this just be a duplication of what reorder-python-imports does?

[asottile]

for the most part, yeah