Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce .publish target for npm_package #1074

Merged
merged 11 commits into from
May 23, 2023
Merged

feat: introduce .publish target for npm_package #1074

merged 11 commits into from
May 23, 2023

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented May 18, 2023 •
edited
Loading

Type of change

Test plan

  • New test cases added

@thesayyn thesayyn requested a review from gregmagolan May 18, 2023 01:19
thesayyn
thesayyn commented May 18, 2023
View reviewed changes
MODULE.bazel Show resolved Hide resolved
@thesayyn thesayyn requested a review from gregmagolan May 18, 2023 19:55
@thesayyn thesayyn enabled auto-merge (squash) May 18, 2023 20:49
@gregmagolan
Copy link
Member

@thesayyn Can you also add an opt-out attribute so that users can disable the .publish target for cases where they don't want it to show up in the graph at all?

@thesayyn
Copy link
Member Author

@thesayyn Can you also add an opt-out attribute so that users can disable the .publish target for cases where they don't want it to show up in the graph at all?

Does no_publish seem reasonable? or publish_binary = True | False?

@gregmagolan
Copy link
Member

Chatted with Alex and he thinks it's not needed. We can add it in the future if someone asks.

@thesayyn thesayyn disabled auto-merge May 23, 2023 18:30
@thesayyn thesayyn requested a review from gregmagolan May 23, 2023 18:30
gregmagolan
gregmagolan approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@thesayyn thesayyn merged commit e54c82c into main May 23, 2023
@thesayyn thesayyn deleted the npm_package_publish branch May 23, 2023 19:50
@gregmagolan gregmagolan mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .publish run target to npm_package
2 participants
@thesayyn @gregmagolan