chore: rename VERSIONS to TOOL_VERSIONS (for consistency with other r…

…ule sets) add comment about order
aspect-build · Nov 2, 2022 · 2c0b37b · 2c0b37b
1 parent ef4c2c9
commit 2c0b37b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/ts/private/versions.bzl b/ts/private/versions.bzl
@@ -3,7 +3,9 @@
 Update with: 
 curl --silent https://registry.npmjs.org/typescript | jq '[.versions[] | select(.version | test("^[0-9.]+$")) | {key: .version, value: .dist.integrity}] | from_entries'
 """
-VERSIONS = {
+
+# Versions should be ascending order so TOOL_VERSIONS.keys()[-1] is the latest version.
+TOOL_VERSIONS = {
     "0.8.0": "sha512-t4DYxzL6Gt3+TRuJXtmh+3KfcY5iSM8J4lzUgfQkTOr78xFbmor79x/dQEGMaiqO2HJBbFGO3RlIaxPzpP5JMA==",
     "0.8.1": "sha512-/cfem275IES0o4/zVD1UmXfE3k5j2OAianSI2Oa1gYzWhAJ44OjNlXv3LVIj5EZ0fgks/XBtzp8aXVsaYILTVg==",
     "0.8.2": "sha512-rc182AVnpWJ2d6mSAjzALdgEZMJqtsAwPjogw7ch8NRa7iTD8vGG2YoZto1R5Bkt5xCXFcg5SrkRenYtI+poHQ==",

diff --git a/ts/repositories.bzl b/ts/repositories.bzl
@@ -6,9 +6,9 @@ See https://docs.bazel.build/versions/main/skylark/deploying.html#dependencies
 
 load("//ts/private:maybe.bzl", http_archive = "maybe_http_archive")
 load("//ts/private:npm_repositories.bzl", "npm_dependencies")
-load("//ts/private:versions.bzl", TS_VERSIONS = "VERSIONS")
+load("//ts/private:versions.bzl", "TOOL_VERSIONS")
 
-LATEST_VERSION = TS_VERSIONS.keys()[-1]
+LATEST_VERSION = TOOL_VERSIONS.keys()[-1]
 
 # WARNING: any additions to this function may be BREAKING CHANGES for users
 # because we'll fetch a dependency which may be different from one that