fix: include declarations in files of generated tsconfig

aspect-build · Feb 11, 2023 · 77cc0c0 · 77cc0c0
1 parent 914bb40
commit 77cc0c0
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/examples/global_dts/BUILD.bazel b/examples/global_dts/BUILD.bazel
@@ -0,0 +1,13 @@
+load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
+
+ts_project(
+    name = "lib",
+    srcs = [
+        "global.d.ts",
+        "index.ts",
+    ],
+    tsconfig = {
+        "declaration": True,
+    },
+    visibility = ["//examples:__subpackages__"],
+)
diff --git a/examples/global_dts/global.d.ts b/examples/global_dts/global.d.ts
@@ -0,0 +1 @@
+declare function myGlobalFunction(a: number): string
diff --git a/examples/global_dts/index.ts b/examples/global_dts/index.ts
@@ -0,0 +1 @@
+myGlobalFunction(42)
diff --git a/ts/private/ts_config.bzl b/ts/private/ts_config.bzl
@@ -37,7 +37,7 @@ def _ts_config_impl(ctx):
             include_transitive_sources = True,
             include_declarations = True,
             include_npm_linked_packages = True,
-        )
+        ),
     ]
 
     for dep in ctx.attr.deps:
@@ -74,7 +74,8 @@ def _filter_input_files(files, allow_js, resolve_json_module):
     return [
         f
         for f in files
-        if _lib.is_ts_src(f.basename, allow_js) or _lib.is_json_src(f.basename, resolve_json_module)
+        # include typescript, json & declaration sources
+        if _lib.is_ts_src(f.basename, allow_js) or _lib.is_json_src(f.basename, resolve_json_module) or _lib.is_typings_src(f.basename)
     ]
 
 def _write_tsconfig_rule(ctx):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		declare function myGlobalFunction(a: number): string