Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project references fail to build when not clean #186

Closed
rc-glean opened this issue Oct 22, 2022 · 2 comments · Fixed by #187
Closed

Project references fail to build when not clean #186

rc-glean opened this issue Oct 22, 2022 · 2 comments · Fixed by #187
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@rc-glean
Copy link

rc-glean commented Oct 22, 2022

It seems like project references can only build from a clean workspace. Any non-exact future builds will fail

Error:

bazel build //examples/project_references/lib_a:lib_a

INFO: Build option --action_env has changed, discarding analysis cache.
INFO: Analyzed target //examples/project_references/lib_a:lib_a (2 packages loaded, 332 targets configured).
INFO: Found 1 target...
ERROR: /Users/ray/workspace/rules_ts/examples/project_references/lib_a/BUILD.bazel:15:11: output 'examples/project_references/lib_a/lib_a.tsbuildinfo' was not created
ERROR: /Users/ray/workspace/rules_ts/examples/project_references/lib_a/BUILD.bazel:15:11: Compiling TypeScript project //examples/project_references/lib_a:lib_a [tsc -p examples/project_references/lib_a/tsconfig.json] failed: not all outputs were created or valid
Target //examples/project_references/lib_a:lib_a failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1.393s, Critical Path: 0.25s
INFO: 18 processes: 8 internal, 9 local, 1 worker.
FAILED: Build did NOT complete successfully

Repro steps:

git clone https://github.com/aspect-build/rules_ts
cd rules_ts
bazel build //examples/project_references/lib_a:lib_a # works
bazel build //examples/project_references/lib_a:lib_a # works because caches are exact
bazel build --action_env="avariable=1" //examples/project_references/lib_a:lib_a # force an unexact rebuild. Fails
bazel build //examples/project_references/lib_a:lib_a # will now always fail too
bazel clean
bazel build //examples/project_references/lib_a:lib_a # works again

--verbose_failures shows no additional debug info

I'm using an M1 mac if that matters. I haven't ruled out that something else is wrong with my set up. Happy to gather more debug info if there's methods other than verbose_failures

@thesayyn thesayyn added the bug Something isn't working label Oct 24, 2022
@thesayyn thesayyn self-assigned this Oct 24, 2022
@thesayyn
Copy link
Member

I can reproduce the issue. Possibly a duplicate of #128

@thesayyn thesayyn added the duplicate This issue or pull request already exists label Oct 24, 2022
@rc-glean
Copy link
Author

rc-glean commented Oct 24, 2022

Thank you so much Sahin. Just wanted to kudo: between you, @gregmagolan , and @alexeagle , that I'm super impressed with how fast everyone at Aspect responds to and fixes issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants