Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: .tsbuildinfo is not written in subsequent builds #187

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix: .tsbuildinfo is not written in subsequent builds #187

merged 1 commit into from
Oct 28, 2022

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented Oct 24, 2022 •
edited
Loading

fixes #186 #128

@bhavitsharma
Copy link

I patched rules_ts with this PR, and the issue seems to have gone away!

bhavitsharma
bhavitsharma reviewed Oct 24, 2022
View reviewed changes
Copy link

@bhavitsharma bhavitsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the PR. Thanks for the fix!

ts/private/ts_project_worker.js Show resolved Hide resolved
alexeagle
alexeagle approved these changes Oct 25, 2022
View reviewed changes
ts/private/ts_project_worker.js Show resolved Hide resolved
@thesayyn thesayyn force-pushed the tsbuildinfo branch 2 times, most recently from b6b15df to ad107b9 Compare October 28, 2022 16:35
@thesayyn thesayyn marked this pull request as ready for review October 28, 2022 16:36
@thesayyn thesayyn changed the title fix: missing .tsbuildinfo in subsequent builds fix: .tsbuildinfo is not written in subsequent builds Oct 28, 2022
@thesayyn thesayyn merged commit 53b1ee1 into main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavitsharma bhavitsharma bhavitsharma left review comments

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project references fail to build when not clean
3 participants
@thesayyn @bhavitsharma @alexeagle