Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining test cases #23

Closed
29 tasks done
alexeagle opened this issue May 19, 2022 · 2 comments
Closed
29 tasks done

Add remaining test cases #23

alexeagle opened this issue May 19, 2022 · 2 comments
Assignees
@thesayyn
Labels
cleanup Cleanup task test New test or update to existing test
Milestone
1.0

Comments

@alexeagle
Copy link
Member

alexeagle commented May 19, 2022 •
edited
Loading

There are like 20 folders under packages/typescript/test/ts_project in rules_nodejs that have coverage we still want:

  • a
  • allow_js
  • b
  • c
  • data
  • declarationdir
  • declarationdir_with_value
  • declaration_only
  • directory_declarations
  • empty_intermediate
  • esm
  • extends_chain
  • filegroup
  • generated_tsconfig
  • import_package_by_name
  • js_library
  • json
  • jsx
  • ngc
  • outdir
  • output_group
  • rootdir
  • rootdir_with_value
  • simple
  • swc
  • tsbuildinfofile
  • ts_config
  • validation
  • worker
@alexeagle alexeagle self-assigned this May 19, 2022
@alexeagle alexeagle assigned thesayyn and unassigned alexeagle Jun 16, 2022
This was referenced Jul 11, 2022
Merged
Merged
Merged
Merged
Merged
@gregmagolan gregmagolan added this to the 1.0 milestone Aug 10, 2022
@gregmagolan gregmagolan added the test New test or update to existing test label Aug 10, 2022
@alexeagle alexeagle mentioned this issue Oct 10, 2022
Closed
@alexeagle
Copy link
Member Author

Note for this one: in #176 I ported over the tests for composite project references, however I dropped a test case that we'll need to add back: there's a use of args=["--emitBOM"] that we were using to verify arbitrary args get passed to tsc, and then the jasmine test in https://github.com/bazelbuild/rules_nodejs/blob/stable/packages/typescript/test/ts_project/b/b.spec.ts verified that the BOM was written. I couldn't get that green in the same PR, but also there's no particular reason to mix that assertion with the composite project references.
We should make sure to restore that coverage as part of this issue.

@alexeagle
Copy link
Member Author

Need to check:

  • a
  • allow_js
  • b
  • c
  • data
  • declarationdir
  • declarationdir_with_value
  • declaration_only
  • directory_declarations
  • empty_intermediate
  • esm
  • extends_chain
  • filegroup
  • generated_tsconfig
  • import_package_by_name
  • js_library
  • json
  • jsx
  • ngc
  • outdir
  • output_group
  • rootdir
  • rootdir_with_value
  • simple
  • swc
  • tsbuildinfofile
  • ts_config
  • tsconfig-base.json
  • validation
  • worker

alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
test: add case for filegroup of srcs
f62c6ed 
Part of #23
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
test: add case for filegroup of srcs
974a223 
Part of #23
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
test: add case for filegroup of srcs
6a4ac56 
Part of #23

:wq
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
test: add case for filegroup of srcs
e96728c 
Part of #23
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
test: add case for filegroup of srcs
86f5c5b 
Part of #23
@alexeagle alexeagle mentioned this issue Oct 31, 2022
Merged
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
docs: show example of different module outputs
ec6c280 
Part of #23
@alexeagle alexeagle mentioned this issue Oct 31, 2022
Merged
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
test: add case for filegroup of srcs (#211)
beb1807 
* test: add case for filegroup of srcs

Part of #23

* code review comments
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
docs: show example of different module outputs (#212)
ffa32f0 
Part of #23
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
docs: add custom compiler example
99ed454 
part of #23
@alexeagle alexeagle mentioned this issue Oct 31, 2022
Merged
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
docs: add root_dir example
bbe07d0 
part of #23
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
docs: add root_dir example
bc26494 
part of #23
@alexeagle alexeagle mentioned this issue Oct 31, 2022
Merged
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
docs: add custom compiler example (#213)
8323fb9 
part of #23
alexeagle added a commit that referenced this issue Oct 31, 2022
@alexeagle
docs: add root_dir example (#214)
c8cc394 
part of #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thesayyn thesayyn

Labels
cleanup Cleanup task test New test or update to existing test
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@alexeagle @cgrindel @gregmagolan @thesayyn