Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts_validate_options should be a validation action #85

Closed
alexeagle opened this issue Jul 11, 2022 · 2 comments
Closed

ts_validate_options should be a validation action #85

alexeagle opened this issue Jul 11, 2022 · 2 comments
Labels
bazel 6 Requires features / fixes landed in Bazel 6 enhancement New feature or request

Comments

@alexeagle
Copy link
Member

once we force users to upgrade to bazel 6.0 we should adopt
https://docs.bazel.build/versions/main/skylark/rules.html#validation-actions

(note, the feature doesn't exist in Bazel 5 afaict)
@alexeagle
Copy link
Member Author

Also, validation actions give us a way to type-check .d.ts inputs even if no output files are produced. Maybe useful for a "ts_declaration" rule ?

This was referenced Jul 11, 2022
Merged
Closed
@gregmagolan gregmagolan added the bazel 6 Requires features / fixes landed in Bazel 6 label Aug 10, 2022
@gregmagolan gregmagolan added this to the 1.1 milestone Aug 10, 2022
@alexeagle alexeagle mentioned this issue Sep 5, 2022
Merged
@cgrindel cgrindel added enhancement New feature or request prioritized labels Sep 27, 2022
@gregmagolan gregmagolan removed this from the 1.1 milestone Feb 5, 2023
@gregmagolan gregmagolan moved this to 🔖 Ready in Open Source Feb 5, 2023
@alexeagle
Copy link
Member Author

Fixed by @dzbarsky on 2.x branch - thanks!

@github-project-automation github-project-automation bot moved this from On Deck to ✅ Done in Open Source Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bazel 6 Requires features / fixes landed in Bazel 6 enhancement New feature or request
Projects
Open Source
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @cgrindel @gregmagolan