fix: give better error when ts_project should be js_library #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
reviewed
Jul 11, 2022
ts/private/ts_project.bzl
Outdated
| label = "//{}:{}".format(ctx.label.package, ctx.label.name) | ||
| if ctx.attr.transpile: | ||
| if len(typings_srcs) > 0: | ||
| no_outs_msg = """ts_project target {target} has no outputs, but it has typings in srcs. |
There was a problem hiding this comment.
this makes me wonder whether tsc is supposed to type check .d.ts sources as well.
There was a problem hiding this comment.
I think it could - but it doesn't produce any outputs in that case, so it would have to be run as a Bazel "validation action" whose outputs aren't required in the dep graph. I'll note that in #85 (comment)
There was a problem hiding this comment.
Ah cool. I'd expect tsc to at least type check and copy it over if instructed. At least that is what I'd expect.
There was a problem hiding this comment.
I'll add that to the message here.
thesayyn
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72