Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefix host call #184

Merged
merged 1 commit into from
Oct 21, 2022
Merged

fix: prefix host call #184

merged 1 commit into from
Oct 21, 2022

Conversation

thesayyn
Copy link
Member

No description provided.

@thesayyn thesayyn requested a review from jbedard October 21, 2022 15:52
@jbedard
Copy link
Member

jbedard commented Oct 21, 2022

Was this crashing?

@thesayyn
Copy link
Member Author

Was this crashing?

unfortunately, yes. and it went unnoticed. I guess it's time for #114

@thesayyn thesayyn merged commit 1cbe540 into main Oct 21, 2022
@jbedard
Copy link
Member

jbedard commented Oct 21, 2022

unfortunately, yes. and it went unnoticed. I guess it's time for #114

I think we can even write plain js but still typecheck it by putting types in comments and just type inference on its own is useful.

@thesayyn
Copy link
Member Author

unfortunately, yes. and it went unnoticed. I guess it's time for #114

I think we can even write plain js but still typecheck it by putting types in comments and just type inference on its own is useful.

i agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesayyn @jbedard