chore: Add the macOS runner to the matrix strategy #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2023
This was referenced Jan 29, 2023
Closed
|
Tested and verified in a private repository. |
|
Sweet. Thanks for the added coverage 🙏 |
gregmagolan
approved these changes
Feb 2, 2023
alexeagle
added a commit
that referenced
this pull request
Feb 8, 2023
This reverts commit 4b5baa9. MacOS runners consume 10x the resources on GH Actions, so we blew through 90% of our February budget in the first week :( "Your 2,806.00 included minutes used consists of 146.00 Ubuntu 2-core minutes, and 2,660.00 macOS 3-core minutes"
|
I just reverted this in 36be3dd because it blew up our February GH Actions budget for the whole aspect-build org, oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the macOS runner to the matrix strategy of the test workflow job.