fix: ts_project external workspace builds #310
Merged
+160
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
reviewed
Feb 9, 2023
jbedard
reviewed
Feb 9, 2023
jbedard
reviewed
Feb 9, 2023
dgp1130
force-pushed
the
external_ts_project
branch
from
eaa18c6 to
0043de1
Compare
|
Question: Where are the |
|
See |
jbedard
reviewed
Feb 10, 2023
dgp1130
force-pushed
the
external_ts_project
branch
from
0043de1 to
ae5b699
Compare
|
Ah thanks, I did look in |
gregmagolan
reviewed
Feb 11, 2023
gregmagolan
reviewed
Feb 11, 2023
gregmagolan
reviewed
Feb 11, 2023
gregmagolan
reviewed
Feb 11, 2023
gregmagolan
reviewed
Feb 11, 2023
dgp1130
force-pushed
the
external_ts_project
branch
from
ae5b699 to
2e188e7
Compare
|
Thanks for the suggestions @gregmagolan, updated with the fixes! |
gregmagolan
changed the title
gregmagolan
reviewed
Feb 11, 2023
gregmagolan
changed the title
Refs aspect-build#284. This allows `ts_project()` to build correctly while in an external workspace. This commit is a slightly modified version of [this diff](aspect-build#284 (comment)).
…pace Closes aspect-build#284. This sets up two workspaces, one with a `ts_project()` and another which depends on the first. When the second workspace is built, it triggers a build of the `ts_project()` which is under `@lib_wksp`, not the main workspace. This would trigger aspect-build#284 if not properly fixed. Note that we don't actually need to do anything with the `ts_project()` output, we just need to trigger to build, so a `build_test()` is sufficient to reproduce the error.
dgp1130
force-pushed
the
external_ts_project
branch
from
2e188e7 to
0139263
Compare
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this pull request
Feb 12, 2023
Refs #48. This pulls in aspect-build/rules_ts#310 to fix `ts_project()` builds in external workspaces, meaning we can remove the local patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284.
short_pathis not sufficient to handle external paths and we need to stripctx.bin_dir.pathinstead. This updates thets_project()rules as well as adds a regression test which triggers ats_project()target to build from the context of an external workspace.