Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-map-support regressed in 1.2.0 #311

Merged

Conversation

jfirebaugh
Copy link
Contributor

@jfirebaugh jfirebaugh commented Feb 10, 2023

This is a bug report in the form of a PR. It contains a failing example. Test with bazel test --test_output=all //examples/source_map_support/....

This test passes in 7c478da, but fails in ad69d93.

The failing output is:

==================== Test output for //examples/source_map_support/test:stack_trace_support_with_chdir_test:
AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

[
  'at Object.<anonymous> (examples/source_map_support/test/a.js:2:19)'
]

should loosely deep-equal

[
  'at Object.<anonymous> (examples/source_map_support/test/a.ts:2:17)'
]
    at Object.<anonymous> (examples/source_map_support/test/a.js:10:12)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Function.Module._load (node:internal/modules/cjs/loader:878:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47
================================================================================

The diff a.js:2:19 (actual) vs a.ts:2:17 (expected) indicates that the source map is not being applied.

@jfirebaugh jfirebaugh changed the title source-map-support regressed in ad69d9358f47fba10ae46b3e9d4661ec14aef5a3 source-map-support regressed in 1.2.0 Feb 10, 2023
@gregmagolan gregmagolan added bug Something isn't working regression Something that used to work and now isn't labels Feb 13, 2023
@gregmagolan
Copy link
Member

cc @thesayyn

@thesayyn thesayyn changed the base branch from main to source_map February 14, 2023 14:56
@thesayyn thesayyn merged commit 3d168cb into aspect-build:source_map Feb 14, 2023
thesayyn added a commit that referenced this pull request Feb 20, 2023
@jfirebaugh jfirebaugh deleted the jfirebaugh/source-map-support branch February 21, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something that used to work and now isn't
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants