Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated typescript versions #353

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Updated typescript versions #353

merged 2 commits into from
Apr 28, 2023

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Apr 13, 2023

Type of change

  • Chore (any other change that doesn't affect source or test files)

Test plan

  • Covered by existing test cases

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gregmagolan gregmagolan self-requested a review April 16, 2023 15:57
@gregmagolan
Copy link
Member

cc @thesayyn for test-worker CI failures

@thesayyn
Copy link
Member

cc @thesayyn for test-worker CI failures

i have 1.0 coming up for rules_oci. so i won't be able to take a look this week.

@alexeagle
Copy link
Member

To unblock this, I'm just going to fix up the worker test to still test against the current version rather than 5.0.

They are currently broken and we're not ready to fix that yet.
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit a94951a into aspect-build:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants