Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make typescript version selection easier #5

Merged
merged 3 commits into from
May 3, 2022
Merged

feat: make typescript version selection easier #5

merged 3 commits into from
May 3, 2022

Conversation

alexeagle
Copy link
Member

  • read from package.json in the typical case
  • mirror version info from the registry so you can just give us a version number
  • advanced users can still declare their own npm_typescript repo to bypass all of it

@alexeagle alexeagle requested review from jbedard and gregmagolan May 2, 2022 01:05
@alexeagle alexeagle force-pushed the ts_version_check branch from d3c6b0f to 7778e00 Compare May 2, 2022 01:07
@alexeagle
feat: make typescript version selection easier
f842ec4 
- read from package.json in the typical case
- mirror version info from the registry so you can just give us a version number
- advanced users can still declare their own npm_typescript repo to bypass all of it
@alexeagle alexeagle force-pushed the ts_version_check branch from 7778e00 to f842ec4 Compare May 2, 2022 01:10
jbedard
jbedard reviewed May 2, 2022
View reviewed changes
ts/repositories.bzl Outdated Show resolved Hide resolved
jbedard
jbedard reviewed May 2, 2022
View reviewed changes
ts/repositories.bzl Outdated Show resolved Hide resolved
jbedard
jbedard reviewed May 2, 2022
View reviewed changes
ts/repositories.bzl Outdated Show resolved Hide resolved
jbedard
jbedard approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@jbedard jbedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if others want to take a look but lgmt

gregmagolan
gregmagolan approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit 7744604 into main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeagle @jbedard @gregmagolan