Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary JsInfo hasattr calls #632

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jun 24, 2024

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from gregmagolan June 24, 2024 21:33
Copy link

aspect-workflows bot commented Jun 24, 2024

Test

All tests were cache hits

79 tests (100.0%) were fully cached saving 14s.


Buildifier      Format

@jbedard jbedard requested review from thesayyn and alexeagle June 25, 2024 17:35
@jbedard jbedard enabled auto-merge (squash) June 26, 2024 00:25
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbedard jbedard merged commit 814b91e into aspect-build:main Jun 27, 2024
23 checks passed
alexeagle pushed a commit to MichaelMitchell-at/rules_ts that referenced this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants