feat: allow definition of alternative typescript repositories #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard-coding the npm_typescript repo was a design smell, and prevented users from having multiple.
|
kormide
approved these changes
Aug 23, 2024
gzm0
added a commit
to gzm0/rules_ts
that referenced
this pull request
Sep 13, 2024
This is a follow-up to aspect-build#675 which made the `@npm_typescript` repository less special. This replaces the (hopefully) last occurrence of this special name that cannot be changed by configuration. Alternatives I considered: - Expose the `is_typescript_5_or_greater` flag on the `ts_project` macro: Simplest option at first, but since it is only used for config validation, that would become nonsensical. - Add a `npm_typescript_package` or `npm_typescript_repository` parameter that would allow overriding all places where `@npm_typescript//` is used by default: Would offer more functionality (e.g. worker config checking), but would also be more invasive.
jbedard
pushed a commit
that referenced
this pull request
Sep 17, 2024
This is a follow-up to #675 which made the `@npm_typescript` repository less special. This replaces the (hopefully) last occurrence of this special name that cannot be changed by configuration. Alternatives I considered: - Expose the `is_typescript_5_or_greater` flag on the `ts_project` macro: Simplest option at first, but since it is only used for config validation, that would become nonsensical. - Add a `npm_typescript_package` or `npm_typescript_repository` parameter that would allow overriding all places where `@npm_typescript//` is used by default: Would offer more functionality (e.g. worker config checking), but would also be more invasive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard-coding the npm_typescript repo was a design smell, and prevented users from having multiple.
Changes are visible to end-users: yes
Test plan