Support TypeScript workers with isolated declarations and custom TypeScript #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MichaelMitchell-at
force-pushed
the
support_ts_workers
branch
from
ad63746 to
9075e43
Compare
|
jbedard
reviewed
Oct 1, 2024
jbedard
reviewed
Oct 1, 2024
jbedard
reviewed
Oct 1, 2024
|
@jbedard updated! |
MichaelMitchell-at
force-pushed
the
support_ts_workers
branch
from
70d9d4a to
e0b00bf
Compare
MichaelMitchell-at
force-pushed
the
support_ts_workers
branch
from
e0b00bf to
55521dc
Compare
jbedard
reviewed
Oct 3, 2024
jbedard
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've successfully tested this on Airtable's code base. Memory usage can be a problem when typechecking a lot of targets. Something like what @alexeagle requested in bazelbuild/bazel#12165 (comment) might be useful. I'm still playing around with
--experimental_total_worker_memory_limit_mband--experimental_shrink_worker_poolto see if they can prevent OOMs.Also, I don't know why, but I have not encountered #361 and I don't believe any changes in this PR would have done anything to fix that issue.