Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add resolve_json_module with esm imports of package.json #711

Merged
merged 1 commit into from
Oct 8, 2024
Merged

test: add resolve_json_module with esm imports of package.json #711

merged 1 commit into from
Oct 8, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 7, 2024

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard mentioned this pull request Oct 7, 2024
Open
@jbedard jbedard requested a review from dzbarsky October 7, 2024 23:17
@jbedard jbedard marked this pull request as ready for review October 7, 2024 23:17
@jbedard jbedard enabled auto-merge (squash) October 8, 2024 00:22
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Oct 8, 2024 •
edited
Loading

Test

3 test targets passed

Targets 
//examples/resolve_json_module_esm:test [k8-fastbuild]              28ms
//examples/resolve_json_module_esm:ts-with-json [k8-fastbuild]      124ms
//examples/resolve_json_module_esm:ts_typecheck_test [k8-fastbuild] 33ms

Total test execution time was 185ms. 136 tests (97.8%) were fully cached saving 10s.

Buildifier      Format

@jbedard jbedard merged commit b04439b into aspect-build:main Oct 8, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzbarsky dzbarsky dzbarsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @dzbarsky