Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always declare a ts_project _types target to fetch dts files #715

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 11, 2024

Sometimes the dts files need to be fetched, there is no reason this shouldn't be done when a transpiler is not being used.

This makes the declare targets more predictable.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

ts_project(name) declaration files can be fetched using the {name}_types target.

Test plan

  • Covered by existing test cases
  • New test cases added

Copy link

aspect-workflows bot commented Oct 11, 2024

Test

All tests were cache hits

140 tests (100.0%) were fully cached saving 10s.


Buildifier      Format

@jbedard jbedard enabled auto-merge (rebase) October 11, 2024 21:51
@dzbarsky dzbarsky disabled auto-merge October 12, 2024 01:20
@dzbarsky
Copy link
Collaborator

@jbedard disabled auto merge so you an address the comment

@jbedard jbedard enabled auto-merge (rebase) October 12, 2024 02:07
@jbedard jbedard merged commit a6a7588 into aspect-build:main Oct 12, 2024
24 checks passed
@jbedard jbedard deleted the types-target branch October 13, 2024 22:41
@jfirebaugh
Copy link
Contributor

The docs in https://github.com/aspect-build/rules_ts/blob/main/docs/transpiler.md#macro-expansion should be updated to say that the [name]_types expansion is always generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants