ts_project: ensure assets get propagated #742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#533, in fixing the issue caused by #493, also omitted adding assets that shouldn't be copied to the
JsInfo
provider. As a result, downstream rules (such asesbuild
) will fail to find the file because it never collected it.Changes are visible to end-users: no
Test plan
Easiest way to repro this issue is to pipe the existing test cases into an
esbuild
bundle. The target should fail with[plugin: bazel-sandbox] Could not resolve "./generated.json"
.