Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup ts_project(isolated_typecheck) logic #751

Merged
merged 1 commit into from
Dec 20, 2024
Merged

refactor: cleanup ts_project(isolated_typecheck) logic #751

merged 1 commit into from
Dec 20, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Dec 17, 2024

This kept confusing me, even though I wrote it 😅

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested review from dzbarsky and Aghassi December 17, 2024 00:17
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Dec 17, 2024 •
edited
Loading

Test

All tests were cache hits

154 tests (100.0%) were fully cached saving 9s.

Buildifier      Format

@jbedard jbedard requested a review from alexeagle December 20, 2024 18:48
@jbedard jbedard merged commit bbce476 into aspect-build:main Dec 20, 2024
24 checks passed
@jbedard jbedard deleted the isolated-typecheck-clearer branch December 20, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@dzbarsky dzbarsky Awaiting requested review from dzbarsky

@Aghassi Aghassi Awaiting requested review from Aghassi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @alexeagle