This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Make SHA256 algorithm creation FIPS compliant. #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
commented
Jun 7, 2017
|
|
||
| namespace Microsoft.AspNetCore.Antiforgery.Internal | ||
| { | ||
| public static class CryptographyAlgorithms |
There was a problem hiding this comment.
Looked like we haven't jumped on the train of just making these things actually internal so I left this public for consistency.
pranavkm
approved these changes
Jun 7, 2017
|
|
||
| try | ||
| { | ||
| sha256 = SHA256.Create(); |
There was a problem hiding this comment.
Just return from here? Shouldn't need the variable.
| return sha256; | ||
| } | ||
| } | ||
| } |
NTaylorMullen
force-pushed
the
nimullen/144
branch
from
2b32354 to
73f0b4c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#144