This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
* Add logging for other IAntiforgery public methods #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| _logger.ReusedCookieToken(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove this addition.
Would potentially logging multiple times per request. Should instead restore the block where SaveCookieTokenAndHeader() is called in GetAndStoreTokens(). Then duplicate that logic in SetCookieTokenAndHeader(). That way, logging can reliably be done once -- when HaveStoredNewCookieToken is false.
Note as well that this method is called in cases (GetTokens()) where the cookie isn't stored at all.
|
⌚ |
|
🆙 📅 @dougbu I believe that's what you meant? |
|
@ryanbrandenburg yup, this is what I meant. |
|
|
ryanbrandenburg
force-pushed
the
rybrande/AddLogging
branch
from
6a99899 to
a8dbf6a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
cc @dougbu and @rynowak