-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes link in NuGet package is out-of-date #178
Comments
Just to confirm: @Eilon you mean update the .nuspec files? |
@dougbu ultimately the NUSPEC needs to change, yes. But I have no idea how the link ends up there. (Manually edit NUSPEC? CSPROJ? Other script?) |
🆗 the .nuspec files are mostly in TFS but tracking here is fine. There are two .nuspec files in this repo in this repo anyhow. I'm putting this into 3.2.7. I'm assuming we don't need to rebuild 3.2.6 for this? |
When does 3.2.6 ship? What is its current state? |
3.2.6 is the current release. We don't have a timeline for 3.2.7 yet. |
Maybe I'm confused - then how could we rebuild 3.2.6 if it already shipped? |
Only by overwriting the packages. That would "fix" what shows up on NuGet.org but leave anyone downloading the latest unaffected. (Seems fine because the metadata is primary used on NuGet.org.) |
Packages cannot be overwritten on NuGet.org. |
@Eilon given
I propose we remove the |
Yeah remove release notes. If we link to the repo, whatever we post (if anything) can be found here. |
FYI the old release note links went different places for MVC, Web.API, …:
The last one was a fallback for packages (e.g. Microsoft.AspNet.Facebook.nupkg) not covered elsewhere. But, it was even more out-of-date. |
Done in changeset 1728218 |
E.g. go here: https://www.nuget.org/packages/Microsoft.AspNet.WebApi/5.2.6
And there is a link to http://go.microsoft.com/fwlink/?LinkID=403010, which redirects to https://docs.microsoft.com/en-us/aspnet/web-api/overview/releases/whats-new-in-aspnet-web-api-22, which is from 2014.
We should not change the FWLink's target because that will make older packages incorrect.
I recommend we change the Release Notes entry to point to this repo: https://github.com/aspnet/AspNetWebStack and then from there people can get whatever info they want.
The text was updated successfully, but these errors were encountered: