Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes link in NuGet package is out-of-date #178

Closed
Eilon opened this issue Jul 11, 2018 · 12 comments
Closed

Release notes link in NuGet package is out-of-date #178

Eilon opened this issue Jul 11, 2018 · 12 comments
Assignees
Labels
3 - Done bug cost: XS Will take up to half a day to complete
Milestone

Comments

@Eilon
Copy link
Member

Eilon commented Jul 11, 2018

E.g. go here: https://www.nuget.org/packages/Microsoft.AspNet.WebApi/5.2.6

And there is a link to http://go.microsoft.com/fwlink/?LinkID=403010, which redirects to https://docs.microsoft.com/en-us/aspnet/web-api/overview/releases/whats-new-in-aspnet-web-api-22, which is from 2014.

We should not change the FWLink's target because that will make older packages incorrect.

I recommend we change the Release Notes entry to point to this repo: https://github.com/aspnet/AspNetWebStack and then from there people can get whatever info they want.

@dougbu
Copy link
Member

dougbu commented Jul 24, 2018

Just to confirm: @Eilon you mean update the .nuspec files?

@Eilon
Copy link
Member Author

Eilon commented Jul 25, 2018

@dougbu ultimately the NUSPEC needs to change, yes. But I have no idea how the link ends up there. (Manually edit NUSPEC? CSPROJ? Other script?)

@dougbu dougbu added this to the 3.2.7 milestone Jul 25, 2018
@dougbu dougbu added the bug label Jul 25, 2018
@dougbu
Copy link
Member

dougbu commented Jul 25, 2018

🆗 the .nuspec files are mostly in TFS but tracking here is fine. There are two .nuspec files in this repo in this repo anyhow.

I'm putting this into 3.2.7. I'm assuming we don't need to rebuild 3.2.6 for this?

@Eilon
Copy link
Member Author

Eilon commented Jul 25, 2018

When does 3.2.6 ship? What is its current state?

@dougbu
Copy link
Member

dougbu commented Jul 25, 2018

3.2.6 is the current release. We don't have a timeline for 3.2.7 yet.

@Eilon
Copy link
Member Author

Eilon commented Jul 25, 2018

Maybe I'm confused - then how could we rebuild 3.2.6 if it already shipped?

@dougbu
Copy link
Member

dougbu commented Jul 25, 2018

Only by overwriting the packages. That would "fix" what shows up on NuGet.org but leave anyone downloading the latest unaffected. (Seems fine because the metadata is primary used on NuGet.org.)

@Eilon
Copy link
Member Author

Eilon commented Jul 25, 2018

Packages cannot be overwritten on NuGet.org.

@dougbu dougbu self-assigned this Nov 6, 2018
@dougbu
Copy link
Member

dougbu commented Nov 17, 2018

@Eilon given

I propose we remove the <releaseNotes> elements from our .nuspec files. Thoughts?

@Eilon
Copy link
Member Author

Eilon commented Nov 19, 2018

Yeah remove release notes. If we link to the repo, whatever we post (if anything) can be found here.

@dougbu dougbu added cost: XS Will take up to half a day to complete 2 - Working and removed 1 - Ready 2 - Working labels Nov 19, 2018
@dougbu
Copy link
Member

dougbu commented Nov 28, 2018

Done in changeset 1728218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done bug cost: XS Will take up to half a day to complete
Projects
None yet
Development

No branches or pull requests

2 participants