Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet Package : Add repository metadata. #190

Closed
MaximRouiller opened this issue Aug 17, 2018 · 12 comments · Fixed by #192
Closed

NuGet Package : Add repository metadata. #190

MaximRouiller opened this issue Aug 17, 2018 · 12 comments · Fixed by #192
Assignees
Labels
3 - Done cost: XS Will take up to half a day to complete enhancement
Milestone

Comments

@MaximRouiller
Copy link
Contributor

Basically, we can now add a repository metadata on a nuspec file to allow the repository to be surfaced on NuGet. This allows you to have a projectUrl as well a repository URL now.

I've talked about it on Twitter but the most basic things to know is here:

NuSpec Reference

Reference Implementation in Json .NET
image

@natemcmaster
Copy link

cc @Eilon - we do this already on ASP.NET Core packages. I think it's worth adding to older nuspec's. No need to trigger a new release for this, but next time there is a release, it would be good to have this in the package metadata.

@Eilon
Copy link
Member

Eilon commented Aug 20, 2018

Yeah I'm fine with that.

@MaximRouiller
Copy link
Contributor Author

@natemcmaster are you doing the PR or should I?

@natemcmaster
Copy link

Feel free to send a PR. @Eilon who services this repo and could help bring in the change?

@MaximRouiller
Copy link
Contributor Author

@natemcmaster @Eilon does https://github.com/aspnet/AspNetWebStack/blob/master/Directory.Build.props makes sense to you as to where I should add it to have it imported into everything?

@Eilon
Copy link
Member

Eilon commented Aug 21, 2018

@mkArtakMSFT runs this repo, and @dougbu is the main expert.

@dougbu
Copy link
Member

dougbu commented Aug 21, 2018

Feel free to send a PR to change src/WebApiHelpPage/WebApiHelpPage.nuspec and src/WebApiHelpPage/VB/WebApiHelpPage.VB.nuspec. We appreciate the help.

We'll handle the remaining packaging which is in an internal repository.

@dougbu dougbu added this to the 3.2.7 milestone Aug 21, 2018
@MaximRouiller
Copy link
Contributor Author

@dougbu whenever you're ready.

dougbu added a commit that referenced this issue Aug 22, 2018
changes to repository url, see issue #190
@dougbu
Copy link
Member

dougbu commented Aug 22, 2018

Thanks @MaximRouiller

@dougbu dougbu reopened this Aug 22, 2018
@dougbu
Copy link
Member

dougbu commented Aug 22, 2018

2109e7e takes care of this repository. Remaining work is in internal packages.

@dougbu
Copy link
Member

dougbu commented Nov 28, 2018

Remainder done in changeset 1728218

@MaximRouiller
Copy link
Contributor Author

@dougbu Thank you so much!

cc @spboyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done cost: XS Will take up to half a day to complete enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants