Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use msbuild from VS 2022 if available #395

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Mar 4, 2023

  • should ease local and TeamCity builds
  • nit: switch to 64bit msbuild

@dougbu dougbu requested review from javiercn, MackinnonBuck, wtgodbe, mkArtakMSFT and a team March 4, 2023 03:17
@dougbu dougbu force-pushed the dougbu/installed.vs branch 2 times, most recently from e0e7859 to 190416c Compare March 6, 2023 05:41
dougbu added 3 commits March 6, 2023 17:27
- should ease local and TeamCity builds
- make `%InstallDir%` unquoted (unlike `%vswhere%`)
  - shorten `%Path%` slightly
- nits:
  - switch to 64bit `msbuild`
  - use script location more; no need to change directories
- follow up to aspnet#396
  (unsure why new FxCop and "spelling" errors didn't fail that PR)
@dougbu dougbu force-pushed the dougbu/installed.vs branch from 190416c to 7ca7468 Compare March 7, 2023 05:07
@dougbu
Copy link
Member Author

dougbu commented Mar 7, 2023

@wtgodbe I normally don't worry too much about this repo's build and test flakiness. In this case however, I seem to have changed timings enough for some incorrect assemblies to land in bin/$(Configuration)/Test/ (causing assembly load issues in Moq) and for significantly increased port reservation issues e.g. System.ServiceModel.AddressAlreadyInUseException : HTTP could not register URL http://localhost:50235/ because TCP port 50235 is being used by another application.

My efforts so far haven't worked and I may back out my latest (xUnit collection) commit. In the meantime, I'm going to try another thing or two. First, calling in the big guns…


@halter73 @Tratcher could you please have a look at the logic in the PortReserver class❔ I don't see anything obviously wrong in it and was surprised the xUnit collection approach didn't help much. I suspect there's something fundamentally wrong. Note however that the class iseems to be used correctly i.e., instances are disposed everywhere they should be.

- seems to resolve `Moq` assembly load issue
@dougbu
Copy link
Member Author

dougbu commented Mar 7, 2023

I forgot to mention: The issues related to PortReserver aren't new in this PR. It's more that retrying builds doesn't seem to work these days.

@dougbu
Copy link
Member Author

dougbu commented Mar 7, 2023

Oh, wow, that worked. Suspect gremlins will crop up again but merging for now.

@Tratcher and @halter73, it's less urgent but your thoughts may help during the long live of this repo.

@dougbu dougbu merged commit 2da072a into aspnet:main Mar 7, 2023
@dougbu dougbu deleted the dougbu/installed.vs branch March 7, 2023 06:07
@dougbu
Copy link
Member Author

dougbu commented Mar 7, 2023

Somewhat predictably, build #20230306.4 immediately after this PR validated on its first attempt for this iteration failed w/ lots of port reservation problems. Hopefully there's something in PortReserver that jumps out at you @Tratcher and @halter73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants