Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable collection of new EventCounters in Kestrel #1513

Closed
shirhatti opened this issue May 12, 2020 · 1 comment · Fixed by #1529
Closed

Enable collection of new EventCounters in Kestrel #1513

shirhatti opened this issue May 12, 2020 · 1 comment · Fixed by #1529

Comments

@shirhatti
Copy link

We just added new EventCounters in Kestrel. We should enable collecting them in our perf runs
dotnet/aspnetcore#21649

[EventSource(Name = "Microsoft-AspNetCore-Server-Kestrel")]

connections-per-second
total-connections
tls-handshakes-per-second
total-tls-handshakes
current-tls-handshakes
failed-tls-handshakes
current-connections
connection-queue-length
request-queue-length
current-upgraded-requests
@shirhatti shirhatti mentioned this issue May 12, 2020
Merged
roji added a commit to roji/AspNetBenchmarks that referenced this issue May 30, 2020
@roji
Support additional perf counter providers
a01c577 
* Extends infrastructure to allow specifying arbitrary number of
  perf counter providers.
* Add support for Kestrel and Npgsql counters.

Closes aspnet#1513
@roji roji mentioned this issue May 30, 2020
Merged
sebastienros pushed a commit that referenced this issue Jun 2, 2020
@roji
Support additional perf counter providers (#1529)
60ec822 
* Extends infrastructure to allow specifying arbitrary number of
  perf counter providers.
* Add support for Kestrel and Npgsql counters.

Closes #1513
@leonids2005
Copy link

request-queue-length

why it does not work with HTTP/1? Actually, this information is not clearly stated in the docs :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support additional perf counter providers roji/AspNetBenchmarks
2 participants
@shirhatti @leonids2005