Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common external package version variables #147

Closed
wants to merge 1 commit into from

Conversation

BrennanConroy
Copy link
Member

@dnfclas
Copy link

dnfclas commented Jan 17, 2017

Hi @BrennanConroy, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@natemcmaster
Copy link
Contributor

What will be the corresponding change for something that consumes the Internal.AspNetCore.Sdk project, like aspnet/Common?

@pranavkm
Copy link
Contributor

@natemcmaster - we're going to update individual repos to include this value. I guess we can do that once this package builds.

@mikaelm12
Copy link

😄

@natemcmaster
Copy link
Contributor

I don't think that'll work. The package isn't installed when you run restore for the first time.

@natemcmaster
Copy link
Contributor

Recommend either creating Internal.AspNetCore.Test.Sdk which depends on the xunit version we need, or waiting until dotnet/msbuild#1493 is ready

@BrennanConroy BrennanConroy deleted the brecon/version branch January 17, 2017 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants