#1075 Suppress exceptions from failing to load HostingStartup assemblies

aspnet · May 23, 2017 · 7ac6842 · 7ac6842
1 parent 68d1d4c
commit 7ac6842
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs b/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs
@@ -285,12 +285,6 @@ private IServiceCollection BuildCommonServices(out AggregateException hostingSta
                 if (exceptions.Count > 0)
                 {
                     hostingStartupErrors = new AggregateException(exceptions);
-
-                    // Throw directly if we're not capturing startup errors
-                    if (!_options.CaptureStartupErrors)
-                    {
-                        throw hostingStartupErrors;
-                    }
                 }
             }
 

diff --git a/test/Microsoft.AspNetCore.Hosting.Tests/WebHostBuilderTests.cs b/test/Microsoft.AspNetCore.Hosting.Tests/WebHostBuilderTests.cs
@@ -975,17 +975,18 @@ public void Build_HostingStartupFromPrimaryAssemblyCanBeDisabled()
         }
 
         [Fact]
-        public void Build_ThrowsIfUnloadableAssemblyNameInHostingStartupAssemblies()
+        public void Build_DoesntThrowIfUnloadableAssemblyNameInHostingStartupAssemblies()
         {
             var builder = CreateWebHostBuilder()
                 .CaptureStartupErrors(false)
                 .UseSetting(WebHostDefaults.HostingStartupAssembliesKey, "SomeBogusName")
                 .Configure(app => { })
                 .UseServer(new TestServer());
 
-            var ex = Assert.Throws<AggregateException>(() => builder.Build());
-            Assert.IsType<InvalidOperationException>(ex.InnerExceptions[0]);
-            Assert.IsType<FileNotFoundException>(ex.InnerExceptions[0].InnerException);
+            using (builder.Build())
+            {
+                Assert.Equal("0", builder.GetSetting("testhostingstartup"));
+            }
         }
 
         [Fact]