Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

RC2 Templates Review follow-up: Remove UseDefaultHostingConfiguration #727

Closed
rustd opened this issue Apr 26, 2016 · 8 comments
Closed

RC2 Templates Review follow-up: Remove UseDefaultHostingConfiguration #727

rustd opened this issue Apr 26, 2016 · 8 comments
Assignees
Milestone

Comments

@rustd
Copy link

rustd commented Apr 26, 2016

From the templates review, it was brought up that the following line of code (https://github.com/aspnet/Templates/blob/dev/src/BaseTemplates/StarterWeb/Program.cs#L18) should be removed from the templates. Please make the corresponding FX changes.

               // ToDo: Open a bug
                .UseDefaultHostingConfiguration(args)

@muratg FYI

@muratg muratg added this to the 1.0.0-rc2 milestone Apr 26, 2016
@muratg
Copy link

muratg commented Apr 26, 2016

@JunTaoLuo This is from the templates review today. Please have a look, and send a mail to @Eilon and @DamianEdwards for approval.

cc @Tratcher

@muratg
Copy link

muratg commented Apr 26, 2016

#700

@khellang
Copy link
Contributor

@muratg During the template review, did you discuss IStartup/StartupBase/ConventionBasedStartup? 😄

@davidfowl
Copy link
Member

We didn't but I don't see us using that interface in the templates.

@khellang
Copy link
Contributor

So that means ConventionBasedStartup implicitly, like today?

@DamianEdwards
Copy link
Member

It did come up as I thought we were making that change (to use IStartup). For now it appears we're staying with the convention based approach in the templates by default.

@khellang
Copy link
Contributor

Alright. As long as I can opt-out (of the conventions), I'm all good 😄

@JunTaoLuo
Copy link
Contributor

Need to track the updates of our samples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants