This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 307
RC2 Templates Review follow-up: Remove UseDefaultHostingConfiguration #727
Comments
@JunTaoLuo This is from the templates review today. Please have a look, and send a mail to @Eilon and @DamianEdwards for approval. cc @Tratcher |
@muratg During the template review, did you discuss IStartup/StartupBase/ConventionBasedStartup? 😄 |
We didn't but I don't see us using that interface in the templates. |
So that means ConventionBasedStartup implicitly, like today? |
It did come up as I thought we were making that change (to use |
Alright. As long as I can opt-out (of the conventions), I'm all good 😄 |
Need to track the updates of our samples. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From the templates review, it was brought up that the following line of code (https://github.com/aspnet/Templates/blob/dev/src/BaseTemplates/StarterWeb/Program.cs#L18) should be removed from the templates. Please make the corresponding FX changes.
@muratg FYI
The text was updated successfully, but these errors were encountered: