Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Self host deployers not testing on full CLR if test app is not published before deployment #728

Closed
JunTaoLuo opened this issue Apr 26, 2016 · 2 comments
Assignees
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Apr 26, 2016

Currently if the app is not published before deployment the command executed by the self host deployer looks like dotnet run -p "C:\gh\Localization\samples\LocalizationSample" -- --server.urls http://localhost:5081/ --server Microsoft.AspNetCore.Server.Kestrel. This is missing the framework specification --framework net451/netcoreapp1.0 and will always run the coreclr version by default. As a result, some of our full CLR functional tests currently are tested with CoreCLR instead. We should update the deployer so we don't have this hole in our test coverage.

@JunTaoLuo JunTaoLuo self-assigned this Apr 26, 2016
@JunTaoLuo JunTaoLuo added the bug label Apr 26, 2016
@JunTaoLuo JunTaoLuo added this to the 1.0.0-rc2 milestone Apr 26, 2016
@Eilon
Copy link
Member

Eilon commented May 5, 2016

@muratg do we want to do this for RC2? If we're missing important test coverage we should add this ASAP.

@muratg
Copy link

muratg commented May 5, 2016

Yes, we should do this now. @JunTaoLuo I assume the change is not that hard (although if tests fail, fixing those may take some time.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants