This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Update self host deployer to target specific framework when lauching without publish #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,8 +74,10 @@ protected CancellationToken StartSelfHost(Uri uri) | |||
| } | |||
| else | |||
| { | |||
| var targetFramework = DeploymentParameters.TargetFramework ?? (DeploymentParameters.RuntimeFlavor == RuntimeFlavor.Clr ? "net451" : "netcoreapp1.0"); | |||
There was a problem hiding this comment.
I'm adding these default targets since I don't think they should change anymore and individual deployers can still override the default by specifying it explicitly. These defaults can also be added to ApplicationDeployer. The reason we had this option previously is because some apps contained multiple .NET Core targets (dnxcore50 and netstandardapp1.5 for example) making default targets less applicable but that is no longer the case.
|
|
|
RC2 approval cc @Eilon @DamianEdwards. I will merge this into release instead of dev on which I accidentally opened this PR. |
|
@JunTaoLuo go for it, and please keep an eye on the CI to make sure that affected tests pass (or disable them and log RC2 bugs to investigate). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#728 As titled.
I'm renaming the property to reflect the fact that it is no longer only used for publishing. This will require changes in Entropy, MusicStore, IISIntegration, ServerTests, Localization.
I have tested this locally, both default targets and explicit targets, to verify that apps are launched in the correct framework but I'll wait for some feedback before seeking RC2 approval.